Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to pylops in LinearOperator notes and ARPACK example #9605

Merged
merged 6 commits into from
Dec 21, 2018
Merged

Reference to pylops in LinearOperator notes and ARPACK example #9605

merged 6 commits into from
Dec 21, 2018

Conversation

mrava87
Copy link
Contributor

@mrava87 mrava87 commented Dec 17, 2018

  • Add reference to pylops project in LinearOperator notes.
  • Added example with LinearOperator to Sparse Eigenvalue Problems with ARPACK tutorial.

… LinearOperator to Sparse Eigenvalue Problems with ARPACK example
@mrava87 mrava87 changed the title Reference to pylops in LinearOperator notes and. ARPACK example Reference to pylops in LinearOperator notes and ARPACK example Dec 17, 2018
@mrava87
Copy link
Contributor Author

mrava87 commented Dec 17, 2018

I didn't realise that the code snippets in your tutorials are actually tested on travis. How should I go about here:

  • add pylops to dependencies for develop (but not user) if this is possible?
  • not use pylops in example in ARPACK tutorial but actually create some operators in the tutorial itself (that may make the code longer and quite verbose).
  • avoid travis from running the snippet (if possible?)

@rgommers rgommers added scipy.sparse.linalg Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Dec 18, 2018
@rgommers
Copy link
Member

not use pylops in example in ARPACK tutorial but actually create some operators in the tutorial itself (that may make the code longer and quite verbose).

This would be preferred. I was thinking something like:

  • example of basic LinearOperator use
  • example of creating an operator (if not too verbose)
  • then a short paragraph explaining that PyLops defines more operators and helps also if you want to create your own. and then a link to PyLops.

@rgommers
Copy link
Member

add pylops to dependencies for develop (but not user) if this is possible?

this is in principle possible, but I don't think we want to do this. refguide_check should also pass locally, so we'd then be requiring devs to also install PyLops.

@mrava87
Copy link
Contributor Author

mrava87 commented Dec 18, 2018 via email

@mrava87
Copy link
Contributor Author

mrava87 commented Dec 18, 2018

Not sure I understand why Travis is giving all these indentation errors (and just for one specific build)?

Is there a way to locally build the doc with checks on the '>>>' codes? If I run python setup.py build_sphinx everything works fine and the documentation looks like I expect it to look

@tylerjereddy
Copy link
Contributor

We have a special script in tools/refguide_check.py that executes the docstrings and checks for the expected output, as you've noticed.

In our continuous integration there is a single matrix entry in travis that includes the command python runtests.py -g --refguide-check, and you should be able to use that locally as a first pass at refining your docstrings so they pass.

@mrava87
Copy link
Contributor Author

mrava87 commented Dec 19, 2018

Thanks a lot, that helps! Will do that :)

@mrava87
Copy link
Contributor Author

mrava87 commented Dec 19, 2018

Now the doctoring checks are successful and Travis builds :) not sure why the CircleCI pypy3 fails as it was working fine before and I did not change any real code. Seems like I can't rerun the workflow from https://circleci.com/gh/scipy/scipy/10468?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, maybe someone with privileges can do it?

@rgommers
Copy link
Member

Don't worry about the PyPy failure, that was just a CI hiccup (Too long with no output (exceeded 10m0s)).

@rgommers
Copy link
Member

overall looks good to me, only a few minor comments.

@rgommers rgommers merged commit bacc926 into scipy:master Dec 21, 2018
@rgommers
Copy link
Member

Thanks @mrava87, merged.

@rgommers rgommers added this to the 1.3.0 milestone Dec 21, 2018
@mrava87
Copy link
Contributor Author

mrava87 commented Dec 21, 2018

Thanks a lot to you for help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.sparse.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants