-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference to pylops in LinearOperator notes and ARPACK example #9605
Conversation
mrava87
commented
Dec 17, 2018
- Add reference to pylops project in LinearOperator notes.
- Added example with LinearOperator to Sparse Eigenvalue Problems with ARPACK tutorial.
… LinearOperator to Sparse Eigenvalue Problems with ARPACK example
I didn't realise that the code snippets in your tutorials are actually tested on travis. How should I go about here:
|
This would be preferred. I was thinking something like:
|
this is in principle possible, but I don't think we want to do this. |
Hi Ralf,
I agree. I can modify the example as you suggest, should be easy to have one or two operators that are simple to create with few lines of code. Will
update the pull request :)
iMR
… On 18 Dec 2018, at 08:00, Ralf Gommers ***@***.***> wrote:
not use pylops in example in ARPACK tutorial but actually create some operators in the tutorial itself (that may make the code longer and quite verbose).
This would be preferred. I was thinking something like:
example of basic LinearOperator use
example of creating an operator (if not too verbose)
then a short paragraph explaining that PyLops defines more operators and helps also if you want to create your own. and then a link to PyLops.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Not sure I understand why Travis is giving all these indentation errors (and just for one specific build)? Is there a way to locally build the doc with checks on the '>>>' codes? If I run python setup.py build_sphinx everything works fine and the documentation looks like I expect it to look |
We have a special script in In our continuous integration there is a single matrix entry in travis that includes the command |
Thanks a lot, that helps! Will do that :) |
Now the doctoring checks are successful and Travis builds :) not sure why the CircleCI pypy3 fails as it was working fine before and I did not change any real code. Seems like I can't rerun the workflow from https://circleci.com/gh/scipy/scipy/10468?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, maybe someone with privileges can do it? |
Don't worry about the PyPy failure, that was just a CI hiccup ( |
overall looks good to me, only a few minor comments. |
… small typo in arpack tutorial.
Thanks @mrava87, merged. |
Thanks a lot to you for help :) |