Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Replace NumPy aliased functions #9888

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@pentschev
Copy link
Contributor

commented Mar 1, 2019

In numpy/numpy#10653, NumPy has replaced duplicate
implementations by aliased functions. Such aliases may not be available in other
NumPy-like libraries (e.g., CuPy), thus breaking compatibility after the
introduction of array_function, as described in NEP-18 [1].

[1] https://www.numpy.org/neps/nep-0018-array-function-protocol.html

cc @mrocklin

MAINT: Replace NumPy aliased functions
In numpy/numpy#10653, NumPy has replaced duplicate
implementations by aliased functions. Such aliases may not be available in other
NumPy-like libraries (e.g., CuPy), thus breaking compatibility after the
introduction of __array_function__, as described in NEP-18 [1].

[1] https://www.numpy.org/neps/nep-0018-array-function-protocol.html
@perimosocordiae
Copy link
Member

left a comment

Changes look good to me. More consistency across the codebase is always nice.

@rgommers rgommers added the maintenance label Mar 1, 2019

@rgommers rgommers merged commit 54e1727 into scipy:master Mar 1, 2019

10 checks passed

ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/circleci: pypy3 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scipy.scipy Build #20190301.17 succeeded
Details
scipy.scipy (Linux_Python_36_32bit_full) Linux_Python_36_32bit_full succeeded
Details
scipy.scipy (Windows Python35-64bit-full) Windows Python35-64bit-full succeeded
Details
scipy.scipy (Windows Python36-32bit-full) Windows Python36-32bit-full succeeded
Details
scipy.scipy (Windows Python36-64bit-full) Windows Python36-64bit-full succeeded
Details
scipy.scipy (Windows Python37-64bit-full) Windows Python37-64bit-full succeeded
Details
@rgommers

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

LGTM too, thanks @pentschev

@rgommers rgommers added this to the 1.3.0 milestone Mar 1, 2019

@pentschev

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

Thanks @perimosocordiae and @rgommers for taking the time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.