-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Avoid inplace modification of input array in newton #9991
Conversation
optimize.newton previously changes the users input array when performing calculations. This PR changes this to perform an explicit copy of the array before any inplace modifications are performed.
Hmm, that looks like a recent regression, hard to believe that |
there's a minor style issue that caused CI to fail |
@rgommers fixed the codestyle issue. Looking at the git history, it seems to have been around for a while.
|
Well, those commits went into 1.2.0, so it's a regression in the latest release because of gh-8357. |
Merged, thanks @Kai-Striega |
@mikofski FYI in case you didn't see it |
This is in the 1.3.x maintenance branch already too--presumably backport label is for 1.2.x LTS. I think that gels with the discussion above. |
optimize.newton previously changes the users input array when
performing calculations. This PR changes this to perform an explicit
copy of the array before any inplace modifications are performed.
closes #9964.