Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object deletion response status #190

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix object deletion response status #190

merged 1 commit into from
Nov 17, 2021

Conversation

almirsarajcic
Copy link
Contributor

@almirsarajcic almirsarajcic commented Nov 17, 2021 •
edited
Loading

S3 returns 204 No Content instead of 200 Success status.

@almirsarajcic
Fix object deletion response status
b554b5b 
S3 returns 204 No Content instead of 200 Success status.
jakobvogel
jakobvogel approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thank you!

Reference: https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObject.html

@andyHa andyHa merged commit ca2b261 into scireum:develop Nov 17, 2021
@jakobvogel
Copy link
Member

Version 7.2.2 with your fix is currently being published.

@almirsarajcic almirsarajcic deleted the delete-object-status-code-fix branch November 17, 2021 21:58
@almirsarajcic
Copy link
Contributor Author

Thanks! That was fast 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobvogel jakobvogel jakobvogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@almirsarajcic @jakobvogel @andyHa