Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Filtering of Bucket Contents in UI #226

Merged
merged 2 commits into from Mar 8, 2023
Merged

Fix: Filtering of Bucket Contents in UI #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de01bbc
Refactors method to abort early 💨
jakobvogel Mar 8, 2023
53e60fa
Decodes key before checking match with query ⚙️
jakobvogel Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/ninja/Bucket.java
View file
Open in desktop
Expand Up @@ -363,9 +363,11 @@ public int countObjects(@Nullable String query) {
}

private boolean isMatchingObject(@Nullable String query, File currentFile) {
return (Strings.isEmpty(query) || currentFile.getName().contains(query))
&& currentFile.isFile()
&& !currentFile.getName().startsWith("$");
if (!currentFile.isFile() || currentFile.getName().startsWith("$")) {
return false;
}

return Strings.isEmpty(query) || StoredObject.decodeKey(currentFile.getName()).contains(query);
}

protected int getVersion() {
Expand Down