Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLF4J compatibility #41

Closed
mcandre opened this issue Aug 1, 2016 · 1 comment
Closed

SLF4J compatibility #41

mcandre opened this issue Aug 1, 2016 · 1 comment

Comments

@mcandre
Copy link

mcandre commented Aug 1, 2016

Please help us use sirius-kernel in larger projects that require SLF4J. Please do at least one of:

  • Don't rely on logging method calls specific to log4j, that are not available in projects that prefer SLF4J.
  • Have sirius-kernel use SLF4J itself, to ensure SLF4J compatibility
  • Show a Maven or Gradle snippet that will work for other projects attempting to include sirius-kernel, in a way that resolves the SLF4J incompatibility
@andyHa
Copy link
Member

andyHa commented Jun 13, 2018

I understand that this issue is outdated - still for future reference:
You need to provide a custom "Setup" class which doesn't setup log4j as default logger for everything.

Using maven you also could then exclude the dependency to log4j. The whole project only relies on our logging interface.

@andyHa andyHa closed this as completed Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants