Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes Amount serialized as number in json #461

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Makes Amount serialized as number in json #461

merged 1 commit into from
Jun 5, 2023

Conversation

mkeckmkeck
Copy link
Contributor

  • previous attempt using toMachineString indeed worked in some cases (in combination with Json#getValueAmount), but using the BigDecimal representation will make Jackson handle all cases properly

@mkeckmkeck
Makes amount serialized as number in json
2254c7d 
- previous attempt using toMachineString indeed worked in some
  cases (in combination with Json#getValueAmount), but using the
  BigDecimal representation will make Jackson handle all cases
  properly
@mkeckmkeck mkeckmkeck added the 🐛 Bugfix Contains only a small fix for an existing bug label Jun 5, 2023
@mkeckmkeck mkeckmkeck merged commit d2a2dd6 into develop Jun 5, 2023
@mkeckmkeck mkeckmkeck deleted the mke/json_serialize_amount_as_number branch June 5, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkeckmkeck @sabieber @jakobvogel @fhaScireum