Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce switchable **opt-out** new-style GRIB1 loading #490

Open
Tracked by #56
trexfeathers opened this issue Jun 18, 2024 · 0 comments
Open
Tracked by #56

Introduce switchable **opt-out** new-style GRIB1 loading #490

trexfeathers opened this issue Jun 18, 2024 · 0 comments
Labels
Dragon Sub-Task 🦎 https://github.com/orgs/SciTools/projects/19?pane=info

Comments

@trexfeathers
Copy link
Contributor

trexfeathers commented Jun 18, 2024

New-style introduced in #489.

Opt-out because we need to force users to experience the new alternative. We don't expect any changes, but we need to get this exposed so we can be sure.

Possible implementations

  • Environment variable - would allow switching without editing code
  • Global Python variable - flexible and simple (but not thread safe)
  • Thread-safe context manager (e.g. iris.FUTURE) - would allow both behaviours within a single script

Deprecation

If the user uses the switch(es), there needs to be an appropriate DeprecationWarning because the switch(es) will not be there forever. Will be removed in X number of releases.

@trexfeathers trexfeathers added the Dragon Sub-Task 🦎 https://github.com/orgs/SciTools/projects/19?pane=info label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dragon Sub-Task 🦎 https://github.com/orgs/SciTools/projects/19?pane=info
Projects
Status: No status
Development

No branches or pull requests

1 participant