enable uploader to support non-uid uploads #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| session_operations = {'$min': dict(timestamp=acquisition['timestamp'])} | ||
| if acquisition.get('timezone'): | ||
| session_operations['$set'] = {'timezone': acquisition['timezone']} | ||
| config.db.sessions.update_one({'_id': session_obj['_id']}, session_operations) |
There was a problem hiding this comment.
I don't see the need for the FIXME here. That behavior is fine and expected.
Also, I thought we decided that the logic on 152 would be removed. We simply don't have timestamps on projects.
There was a problem hiding this comment.
Yeah, I forgot to remove those two lines.
|
LGTM, pending one comment. |
|
Let's leave this hanging for a moment. I'm almost ready to test. |
gsfr
pushed a commit
that referenced
this pull request
Feb 23, 2016
enable uploader to support non-uid uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #158