Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 2.x. #6

Merged
merged 3 commits into from
Nov 1, 2013
Merged

Support Python 2.x. #6

merged 3 commits into from
Nov 1, 2013

Conversation

drakeguan
Copy link
Contributor

  • Fix compatibility of StringIO.
  • Provide an utility fucntion to handle unicode issue in Python 2.x.

@drakeguan
Support Python 2.x.
cfedcdc 
* Fix compatibility of StringIO.
* Provide an utility fucntion to handle unicode issue in Python 2.x.
@sciunto
Copy link
Member

sciunto commented Oct 30, 2013

Hi,

thanks for the pull request.

  • Since, it's supposed to support python2, could you please add 2.7 in travis.yml? Then, travis will check the unittest against this version of python.
  • Could you start a file CONTRIBUTORS.txt and write your name in it (if you would like)?
  • I'm working on the authorization for a new suitable license. Could you write a sentence like "I declare that this contribution was created in whole by me and can be release under BSD-like license or LGPL license".

Cheers.

@drakeguan
Copy link
Contributor Author

Sure. Why not?
So I just add another commit and make a new pull request, right?

@drakeguan
Copy link
Contributor Author

For CONTRIBUTORS.txt, how about copying this one from Pylons? Do you think it's a good idea?

@sciunto
Copy link
Member

sciunto commented Oct 31, 2013

For contributors, let's just start a list of names. I prefer to keep it simple. Like that: https://github.com/scikit-image/scikit-image/blob/master/CONTRIBUTORS.txt

@drakeguan
Make Python2.7 happy with unittests.
d658cf0 
* Use `unicode_literals` to make str in 2.7 as unicode.
* Function `prepare_unicode_to_latex` is created to wrap generation
  of unicode-latex mappings in consideration of unicode.
@drakeguan
Copy link
Contributor Author

It seems to be done.

@drakeguan drakeguan mentioned this pull request Nov 1, 2013
Closed
sciunto added a commit that referenced this pull request Nov 1, 2013
@sciunto
Merge pull request #6 from drakeguan/support-python2.x
e7764b4 
Support Python 2.7.
@sciunto sciunto merged commit e7764b4 into sciunto-org:master Nov 1, 2013
@sciunto
Copy link
Member

sciunto commented Nov 1, 2013

Cool. It's merged. Thanks for your contribution

@drakeguan drakeguan deleted the support-python2.x branch November 2, 2013 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drakeguan @sciunto