-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoughts on spaces API integration #136
Comments
@Thercast Glad you like the package. This sounds good to me! I just applied for it as well so that I can contribute to development How do you want to proceed? Do you have time to work on the code for this, or do you want me to start on it? If you start on it, do follow general style we've used in this package |
Thanks @sckott! I am interested in providing development help (I've been looking to contribute to R packages that wrap APIs) but wanted to get your opinion on whether we should try to leverage some of the functions from the |
okay |
any thoughts on this? |
[Commenting because I had been lurking on this thread for a few weeks] I'd be down with helping implement this if the help was needed. |
AFK but I like your idea of passing the 404 in a friendly way back to the
user. In that way we don't need to keep track of which functions need auth
versus not. I'm still learning the ropes on best practices, but it seems
with `httr` we should be able to get the status of the request back and
configure a stop with a simple message based on it
…On Sep 26, 2017 6:00 PM, "Scott Chamberlain" ***@***.***> wrote:
any thoughts on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_qp6pqDvjH6320aIwyOQ-mPQmzQY6uks5smXPigaJpZM4PKblJ>
.
|
@Thercast i think you meant to put that in discgolf? |
Oh geez yes you are right! Regarding this I looked more closely at the
[aws.s3](https://github.com/cloudyr/aws.s3) package and while it would be a
bit much to depend on it directly (since all their functions require aws
credentials) I think we can adapt most of the key functions to list, add,
delete objects from spaces. I'll try implementing a method to list all
spaces for a user following your structure for the package
…On Sep 26, 2017 6:08 PM, "Scott Chamberlain" ***@***.***> wrote:
@Thercast <https://github.com/thercast> i think you meant to put that in
discgolf?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_qpxLEd53lg_fsSrAf7NF_Wzcd_aQTks5smXXPgaJpZM4PKblJ>
.
|
Sounds good to me! |
@sckott I have preliminary support for a few of the key operations for spaces (listing spaces, listing objects within a space, and creating a new space) ready for your review at this custom branch. I have more polishing to do but didn't want to go too far in case you have different ideas. It turns out that the |
|
@sckott here are some notes:
Yes that's correct. Digital Ocean allows you to create multiple spaces keys, so you can specify the key associated with a bucket during creation.
I agree. One thing I forgot to mention is that the functions will look for environment variables
Makes perfect sense. With a new
I'll do a bit more cleanup (documentation and adding tests) and put together basic print and summary methods for spaces much like your existing methods for droplets before I send a PR. |
All sounds good |
Now that #138 is merged, can you two divy up tasks ti fill out remaining methods for spaces API? |
@amoeba that sounds like a great idea. Please go ahead and create a new issue and we can discuss how to divy up the remaining pieces. |
closing in favor of continuing discussion in #140 |
I'm a big fan of
analogsea
as digital ocean is a huge part of my infrastructure, so thank you so much for creating this package! Recently digital ocean has begun rolling out early access to their new object storage capability (also known as spaces) and I'm fortunate enough to be part of the early beta for access. It operates in a similar way to amazon S3; in fact they tried to make their spaces API quite compatible with the amazon S3 api. I see great potential for this feature and would be glad to work with you on implementing this inanalogsea
if you are interested.The text was updated successfully, but these errors were encountered: