Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the spacing above animals' speech bubbles? #68

Closed
aedobbyn opened this issue Jan 23, 2019 · 4 comments
Closed

Standardize the spacing above animals' speech bubbles? #68

aedobbyn opened this issue Jan 23, 2019 · 4 comments
Milestone

Comments

@aedobbyn
Copy link
Contributor

Spacing above the text differs depending on the animal, e.g. cat vs. chicken.

I think the cat spacing is preferable because there's a smaller gap, but fine as long as they're standard imo. (Removing the "Colors cannot be applied in this environment :( Try using a terminal or RStudio." line in the reprex below for simplicity.)

library(cowsay)

say(by = "cat")
#> 
#>  -------------- 
#> Hello world! 
#>  --------------
#>     \
#>       \
#>         \
#>             |\___/|
#>           ==) ^Y^ (==
#>             \  ^  /
#>              )=*=(
#>             /     \
#>             |     |
#>            /| | | |\
#>            \| | |_|/\
#>       jgs  //_// ___/
#>                \_)
#> 

say(by = "chicken")
#> 
#> 
#>  ----- 
#> Hello world! 
#>  ------ 
#>     \   
#>      \
#>          _
#>        _/ }
#>       `>' \
#>       `|   \
#>        |   /'-.     .-.
#>         \'     ';`--' .'
#>          \'.    `'-./
#>           '.`-..-;`
#>             `;-..'
#>             _| _|
#>             /` /` [nosig]
#> 

Created on 2019-01-23 by the reprex package (v0.2.1)

@sckott
Copy link
Owner

sckott commented Jan 23, 2019

good catch!

@aedobbyn
Copy link
Contributor Author

Thanks! Are you on board with standardizing to cat spacing?

@sckott
Copy link
Owner

sckott commented Jan 24, 2019

yep, sounds good

@sckott
Copy link
Owner

sckott commented Feb 1, 2019

done in #69

@sckott sckott closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants