subset animals on windows for when by='random' #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, and I should have checked with you after that change! |
|
No worries! I have one more commit coming with a test - don't merge quite yet ;) |
|
cool |
|
I think using |
|
Except apparently AppVeyor isn't installing an up-to-date |
|
yeah, |
|
Ha, what are the odds? I updated a bunch of packages this morning, testthat must have been in there... |
|
we can add install |
sckott
added a commit
that referenced
this pull request
Oct 15, 2015
subset animals on windows for when by='random'
|
looks like we're working now after using dev testthat |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to do this just after CRAN submission, but I didn't notice the change in dealing with unicode on windows until I installed from CRAN today.
When you set
by = 'random'(on Windows), it passes thestopon line 8, but the full list of animals is still available to sample from, resulting in a bad unicode animal showing up once in a while.This PR subsets the
animalsvector by removing the animals defined inua