Update say.r adding fillerama wrapper #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapper to fillerama: a filler text generator with quotes from Futurama, Star Wars, Dexter, Monty Python, Doctor Who, and more! Check it out at: http://chrisvalleskey.com/fillerama/
wrapper to fillerama: a filler text generator with quotes from Futurama, Star Wars, Dexter, Monty Python, Doctor Who, and more! Check it out at: http://chrisvalleskey.com/fillerama/
fillerama wrapper added to say.r
|
thanks @onertipaday taking a look |
making some comments on the code as well |
sckott
reviewed
Dec 13, 2016
| @@ -145,6 +145,13 @@ say <- function(what="Hello world!", by="cat", type="message", length=18, | |||
|
|
|||
| if (what == "rms") { | |||
| what <- rmsfact::rmsfact() | |||
| } | |||
|
|
|||
| if (what =="arresteddevelopment"||what=="doctorwho"||what=="dexter"||what=="futurama"||what=="holygrail"||what=="simpsons"||what=="starwars"||what=="loremipsum") { | |||
There was a problem hiding this comment.
just use %in% here, like what %in% c("arresteddevelopment", "doctorwho", "dexter", "futurama", "holygrail", "simpsons", "starwars", "loremipsum")
updated man file for say with additional things that can be passed to what param
Onertipaday fillerama 1
merge master and branch fillerama
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapper to fillerama: a filler text generator with quotes from Futurama, Star Wars, Dexter, Monty Python, Doctor Who, and more! Check it out at: http://chrisvalleskey.com/fillerama/