Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to type="print" in noninteractive mode #72

Merged
merged 2 commits into from May 21, 2019

Conversation

aedobbyn
Copy link
Contributor

@aedobbyn aedobbyn commented May 14, 2019

The way I'm handling the default type now is to set it to null by default and then assign it to "message" if in interactive and "print" if in noninteractive mode to address the other half of #70. Otherwise, type is whatever the user specifies.

If there's a different approach, happy to change it up!

@aedobbyn
Copy link
Contributor Author

aedobbyn commented May 14, 2019

I think appveyor failed because it had trouble installing dplyr? 🤔

Btw I had to open this in Safari to be able to see where the error happened since you can't see the logs in Chrome for me past a certain point 🤷‍♀

@sckott sckott added this to the v0.8 milestone May 21, 2019
@sckott
Copy link
Owner

sckott commented May 21, 2019

nice! works well

@sckott sckott merged commit a5c774a into sckott:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants