-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding yarn support into nodejs images #137
Comments
I modified the NodeJS 8 Dockerfile to (safely) install Yarn 1.5.1 and updated the S2I assembly file to run yarn install, instead of npm install, when a yarn.lock is present. I will create a PR later today. A question that remains: can we rely on the yarn.lock always being available, or should we add an additional flag to force the use of yarn? |
I think first step have to be to add |
@phracek What is the progress of this? I'm trying to run https://github.com/gothinkster/vue-realworld-example-app but keep encountering issues with not being able to use Yarn. Funny enough... I'm actually able to get somewhat there when setting up an environment variable of Was this ever implemented, and if so, is there any documentation anywhere? |
Couldn't yarn be supported in the s2i scripts regardless? We simply install yarn with npm on our custom image, but would prefer if we didn't have to maintain the s2i scripts as well. Wrapping it in a |
@andrewklau Can you please create a pull request with yarn support to this container repository? |
We do not have resources to fix it. The issue is 'stale'. Feel free to re-open it and file PR. |
Yarn is a lot more predictable and has better performance over NPM https://blog.heroku.com/yarn-deterministic-dependency-resolution
It'd be good if we could package yarn into the nodejs images and only use it if a yarn.lock file exists
The text was updated successfully, but these errors were encountered: