Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding yarn support into nodejs images #137

Closed
andrewklau opened this issue Mar 15, 2017 · 6 comments
Closed

Adding yarn support into nodejs images #137

andrewklau opened this issue Mar 15, 2017 · 6 comments

Comments

@andrewklau
Copy link

Yarn is a lot more predictable and has better performance over NPM https://blog.heroku.com/yarn-deterministic-dependency-resolution

It'd be good if we could package yarn into the nodejs images and only use it if a yarn.lock file exists

@fndejong
Copy link

I modified the NodeJS 8 Dockerfile to (safely) install Yarn 1.5.1 and updated the S2I assembly file to run yarn install, instead of npm install, when a yarn.lock is present.

I will create a PR later today. A question that remains: can we rely on the yarn.lock always being available, or should we add an additional flag to force the use of yarn?

fndejong pushed a commit to fndejong/s2i-nodejs-container that referenced this issue Feb 28, 2018
fndejong pushed a commit to fndejong/s2i-nodejs-container that referenced this issue Feb 28, 2018
@omron93
Copy link
Contributor

omron93 commented Mar 1, 2018

I think first step have to be to add yarn in Red Hat Software Collections. You can report bug (http://bugzilla.redhat.com/) which asks it. @notroj Where to get more information about adding new SW into RHSCL?

fndejong pushed a commit to fndejong/s2i-nodejs-container that referenced this issue May 16, 2018
@cdrage
Copy link

cdrage commented Dec 12, 2019

@phracek What is the progress of this? I'm trying to run https://github.com/gothinkster/vue-realworld-example-app but keep encountering issues with not being able to use Yarn.

Funny enough... I'm actually able to get somewhat there when setting up an environment variable of YARN_ENABLED=true for s2i before deploying..

Was this ever implemented, and if so, is there any documentation anywhere?

@eriweb
Copy link

eriweb commented Feb 10, 2022

Couldn't yarn be supported in the s2i scripts regardless?

We simply install yarn with npm on our custom image, but would prefer if we didn't have to maintain the s2i scripts as well.

Wrapping it in a YARN_ENABLED environment variable or similar could let it be up to the user/reader to get yarn installed first

@phracek
Copy link
Member

phracek commented Sep 12, 2023

@andrewklau Can you please create a pull request with yarn support to this container repository?

@phracek
Copy link
Member

phracek commented Jul 3, 2024

We do not have resources to fix it. The issue is 'stale'. Feel free to re-open it and file PR.

@phracek phracek closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants