Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport few changes previously done in RHOAR container #226

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Backport few changes previously done in RHOAR container #226

wants to merge 5 commits into from

Commits on Dec 23, 2019

  1. Move install-time steps to nodejs_container_install file 

    Removing ln -s /usr/lib/node_modules/nodemon/bin/nodemon.js /usr/bin/nodemon
from Dockerfiles because it does not work anyway for SCLs.
Moving it in to nodejs_container_install script that can be used for more actions.

Also fix path for /usr/bin/nodemon symlink, the previous did not work for SCLs.

Similar to RHOAR image, DEBUG_PORT is specified directly in the Dockerfile.

Other steps included in nodejs_container_install file are originally in the install_node.sh file in the RHOAR image.
    @hhorak
    hhorak committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    003267c View commit details
    Browse the repository at this point in the history

  2. Back-port features originally available in the RHOAR images 

    Most notable changes:
* npx is used for nodemon execution
* GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL variables are set
* npm cache is cleared by rm -rf .npm
* npm install is run once more when starting the node
* run npm run build when a build script is present
* run yarn if  is set, although we do not ship yarn in our images
    @hhorak
    hhorak committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    ad070f8 View commit details
    Browse the repository at this point in the history

  3. Use supported fedora 31 for v10 Fedora Dockerfile

    @hhorak
    hhorak committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    de37c3a View commit details
    Browse the repository at this point in the history

  4. Comment out cache clean 

    We've actually had a test for specifically this, that cache is not removed.

It was added by this commit:
sclorg@0e9b5cb

So it is probable better to not removing it.
    @hhorak
    hhorak committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    aa7af39 View commit details
    Browse the repository at this point in the history

  5. Match also singular in the test_incremental_build 

    When only one package is installed, it says added 1 package.

Also print the overall test result after the cleanup messages, so it is more visible.
    @hhorak
    hhorak committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    e9a8394 View commit details
    Browse the repository at this point in the history