Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal registry for testing OpenShift 4 #337

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented May 30, 2022

No description provided.

@phracek
Copy link
Member Author

phracek commented May 31, 2022

[test-openshift]

@phracek
Copy link
Member Author

phracek commented May 31, 2022

[test]

@phracek
Copy link
Member Author

phracek commented Jun 1, 2022

Fedora tests are failing for reason:

1..38
# failed 1 of 38 tests
# time=526537.299ms
----------------------|---------|----------|---------|---------|-------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------------------|---------|----------|---------|---------|-------------------
All files             |   98.42 |     96.1 |     100 |   98.56 |                   
 src                  |     100 |      100 |     100 |     100 |                   
  browser.js          |     100 |      100 |     100 |     100 |                   
  file.js             |     100 |      100 |     100 |     100 |                   
  pino.js             |     100 |      100 |     100 |     100 |                   
 src/lib              |   97.87 |    94.62 |     100 |   98.08 |                   
  caller.js           |   86.66 |       50 |     100 |   86.66 | 14,23             
  deprecations.js     |     100 |      100 |     100 |     100 |                   
  levels.js           |     100 |      100 |     100 |     100 |                   
  meta.js             |     100 |      100 |     100 |     100 |                   
  multistream.js      |    98.5 |    97.22 |     100 |   98.46 | 82                
  proto.js            |     100 |      100 |     100 |     100 |                   
  redaction.js        |     100 |      100 |     100 |     100 |                   
  symbols.js          |     100 |      100 |     100 |     100 |                   
  time.js             |     100 |      100 |     100 |     100 |                   
  tools.js            |   99.62 |       98 |     100 |   99.61 | 417               
  transport-stream.js |   52.38 |       30 |     100 |   55.55 | 20-26,32-35       
  transport.js        |   98.27 |       95 |     100 |   98.27 | 64                
----------------------|---------|----------|---------|---------|-------------------
S2I image 'quay.io/f35/nodejs:16' test FAILED (exit code: 1)
S2I image 'quay.io/f35/nodejs:16' test FAILED (exit code: 1)
 [PASSED] for 'clients' express
 [FAILED] for 'clients' pino
 [PASSED] for 'clients' prom-client

@phracek
Copy link
Member Author

phracek commented Jun 6, 2022

@hhorak @zmiklank Tests are passing but in real life, they failed:

OpenShift tests for rhscl/nodejs-14-rhel7:1 succeeded.
fatal: unrecognized argument: --no-patch
test/test-lib.sh: line 1137: UNSTABLE_TESTS[*]: unbound variable
-> Image for version 14-minimal not built, skipping tests.

Is something missing in calling tests?

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
test/run Outdated Show resolved Hide resolved
@phracek
Copy link
Member Author

phracek commented Jun 8, 2022

[test-all]

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 9, 2022

[test-openshift][test]

@phracek phracek merged commit 2cb4515 into master Jun 9, 2022
@zmiklank zmiklank deleted the use_internal_registry branch November 23, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants