Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PSGI reload #236

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Support PSGI reload #236

merged 5 commits into from
Jun 2, 2022

Conversation

michal-josef-spacek
Copy link
Member

Again rebase of #221

@michal-josef-spacek
Copy link
Member Author

[test]

@michal-josef-spacek michal-josef-spacek mentioned this pull request May 19, 2022
Closed
@yselkowitz
Copy link
Contributor

IIUC the hot deploy option for the other languages, including perl with mod_perl, is a runtime variable. IOW s2i/bin/run looks for an environment variable (provided by the container runtime) and then modifies how the interpreter is executed accordingly, but a rebuild is not required. However, this differs from all of those by requiring the decision to be made at build time. Is there a way to rework this to not require rebuilding?

@michal-josef-spacek
Copy link
Member Author

@yselkowitz ok, good point. I will look to it.

@phracek
Copy link
Member

phracek commented May 23, 2022 •
edited
Loading

@michal-josef-spacek Why do you close #221 and create a newer one?

@phracek
Copy link
Member

phracek commented May 23, 2022

[test-all]

@michal-josef-spacek
Copy link
Member Author

@phracek I rebased this PR to upstream and I created force push of PR. Force push closed PR, I don't know why.

@michal-josef-spacek
Copy link
Member Author

Heh I totally missed possibility of reopening.

phracek
phracek requested changes May 24, 2022
View reviewed changes
5.30-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
test/run-modfcgid Show resolved Hide resolved
test/run-modfcgid Show resolved Hide resolved
@michal-josef-spacek
Copy link
Member Author

[test]

@michal-josef-spacek
Copy link
Member Author

TODO: Move PSGI_RELOAD from assembly to run.

@phracek
Copy link
Member

phracek commented May 30, 2022

[test-all]

1 similar comment
@phracek
Copy link
Member

phracek commented May 31, 2022

[test-all]

@phracek
Copy link
Member

phracek commented May 31, 2022

[test]

@michal-josef-spacek
Copy link
Member Author

[test]

@phracek
Copy link
Member

phracek commented May 31, 2022

Container tests are green.

[test-openshift]

phracek
phracek requested changes May 31, 2022
View reviewed changes
5.30-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.26-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.26-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.26-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.30-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.30-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.32/s2i/bin/assemble Outdated Show resolved Hide resolved
@phracek
Copy link
Member

phracek commented May 31, 2022 •
edited
Loading

Only nitpicking. Nothing else.

@michal-josef-spacek
Copy link
Member Author

[test]

@michal-josef-spacek
Copy link
Member Author

[test-all]

@michal-josef-spacek
Copy link
Member Author

@yselkowitz Seems that this is functional as you need.

phracek
phracek requested changes Jun 1, 2022
View reviewed changes
5.26-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
5.30-mod_fcgid/s2i/bin/assemble Outdated Show resolved Hide resolved
phracek
phracek reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow, why you have moved PLACKUP_ARGS from assemble to run? Can you please describe it a bit more?

@michal-josef-spacek
Copy link
Member Author

I don't follow, why you have moved PLACKUP_ARGS from assemble to run? Can you please describe it a bit more?

#236 (comment)

@michal-josef-spacek
Copy link
Member Author

[test-all]

@michal-josef-spacek
Copy link
Member Author

[test-openshift]

phracek
phracek approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@phracek phracek merged commit 62b17c2 into sclorg:master Jun 2, 2022
@phracek phracek mentioned this pull request Jun 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-josef-spacek @yselkowitz @phracek