Add support for app.sh script so have easy control over how application launched. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
#165 has been merged, please rebase so that we can use the tests in CI |
|
[test] |
pkubatrh
requested changes
Jan 11, 2017
| This is the most general way of executing your application. It will be | ||
| used in the case where you specify a path to an executable script file | ||
| via the `APP_SCRIPT` environment variable, defaulting to a file named | ||
| `app.sh` if it exists. The script is executed directory to launch your |
There was a problem hiding this comment.
I guess directory -> directly?
|
One more thing - this part should also get changed to accommodate for the new APP_SCRIPT variable |
|
Added |
pkubatrh
approved these changes
Jan 24, 2017
|
LGTM. |
|
[test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address issue #126.
Note that you should merge change #165 first as this depends on the test case added in that for uWSGI, which uses an
app.shfile executed from anapp.pyfile. When the change here is then merged, theapp.shfile in the test will take precedence and theapp.shwill be executed directly withapp.pybeing bypassed.Note that this change doesn't do anything about
APP_HOMEas existing code didn't do anything withAPP_HOMEforapp.pyeither. Arguably it should, but this is being dealt with in separate issues and PR.Also note that although the change uses
APP_SCRIPTand refers to it as application script file, encouraging it as being used for a shell script, technically it could be any executable script file, or even a compiled application. A generic name for the environment variable could be used such asAPP_PROGRAMif really want to reflect that, but probably better to encourage it being just used for a shell script which then in turn can execute anything.