-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for app.sh script so have easy control over how application launched. #174
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
#165 has been merged, please rebase so that we can use the tests in CI |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor issue in the README files, otherwise LGTM.
This is the most general way of executing your application. It will be | ||
used in the case where you specify a path to an executable script file | ||
via the `APP_SCRIPT` environment variable, defaulting to a file named | ||
`app.sh` if it exists. The script is executed directory to launch your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess directory -> directly?
One more thing - this part should also get changed to accommodate for the new APP_SCRIPT variable |
Added |
LGTM. |
[test] |
This address issue #126.
Note that you should merge change #165 first as this depends on the test case added in that for uWSGI, which uses an
app.sh
file executed from anapp.py
file. When the change here is then merged, theapp.sh
file in the test will take precedence and theapp.sh
will be executed directly withapp.py
being bypassed.Note that this change doesn't do anything about
APP_HOME
as existing code didn't do anything withAPP_HOME
forapp.py
either. Arguably it should, but this is being dealt with in separate issues and PR.Also note that although the change uses
APP_SCRIPT
and refers to it as application script file, encouraging it as being used for a shell script, technically it could be any executable script file, or even a compiled application. A generic name for the environment variable could be used such asAPP_PROGRAM
if really want to reflect that, but probably better to encourage it being just used for a shell script which then in turn can execute anything.