Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the latest version in imagestreams #394

Merged
merged 4 commits into from
Sep 7, 2020
Merged

Test the latest version in imagestreams #394

merged 4 commits into from
Sep 7, 2020

Conversation

frenzymadness
Copy link
Member

This commit adds support for testing if the latest version is present in imagestreams.

Also, imagestream/python-centos.json is updated into the latest version.
It already exists in https://hub.docker.com/r/centos/python-38-centos7.

Reworked commits from #393 mainly to address distgen issues.

@frenzymadness
Copy link
Member Author

[test-openshift]

@frenzymadness
Copy link
Member Author

There seems to be something weird (maybe in the new common scripts) because the image name it tries to upload contains the tag twice Uploading image rhscl/python-27-rhel7:2.7 as python-27-rhel7:2.7:2.7

@frenzymadness
Copy link
Member Author

@phracek could you please take a look at this? There is another PR waiting for a review so it would be nice to merge this one first.

@phracek
Copy link
Member

phracek commented Aug 13, 2020

LGTM. Thanks for the distgen update. Re-running openshift tests.

[test-openshift]

@frenzymadness
Copy link
Member Author

As I mentioined earlier, the tests are failing on a strange error:

16:44:09 to build a new example application in Ruby.
16:44:12 Uploading image centos/python-27-centos7:2.7 as python-27-centos7:2.7:2.7
16:44:17 Error response from daemon: Get http://172.30.1.1:5000/v1/users/: dial tcp 172.30.1.1:5000: connect: connection refused
16:44:22 Login Succeeded
16:44:22 Error parsing reference: "172.30.1.1:5000/sclorg-test-31971/python-27-centos7:2.7:2.7" is not a valid repository/tag
16:44:22 No resources found.
16:44:22 In project sclorg-test-31971 on server https://127.0.0.1:8443

On the second line, there is a tag in the name of the image mentioned twice.

I've compared your branch against mine and except changes related to distgen there is only one — a different version of the common module — you have an older one and here we have the latest. I'm going to checkout the older version of the common module and report the problem there if I find something suspicious.

@frenzymadness
Copy link
Member Author

[test-openshift]

@frenzymadness frenzymadness mentioned this pull request Aug 14, 2020
Closed
@frenzymadness
Copy link
Member Author

See a bugreport in sclorg/container-common-scripts#164

@frenzymadness
Copy link
Member Author

And there is one more unrelated failure I've seen in the nightly report so I'm going to investigate it as well.

@frenzymadness
Copy link
Member Author

[test-openshift]

@frenzymadness
Copy link
Member Author

The unrelated problem should be fixed now.

@frenzymadness
Copy link
Member Author

Openshift tests seem to be fixed by the revert of common module but there are some new failures without logs 😞

@frenzymadness
Copy link
Member Author

[test]

1 similar comment
@frenzymadness
Copy link
Member Author

[test]

@frenzymadness
Copy link
Member Author

The problem in the common module mentioned earlier is fixed now so I'm updating it to the latest version and we'll see what CI thinks.

@frenzymadness
Copy link
Member Author

[test-openshift]

@frenzymadness
Copy link
Member Author

[test]

@frenzymadness
Copy link
Member Author

[test][test-openshift]

@frenzymadness
Copy link
Member Author

I thought we are close to merging but then I have to rebase it again because imagestreams were reworked in #395 by @hhorak . It means that I removed one commit from this PR because Python 3.8 is already in imagestreams.

Let's see whether these changes are compatible with how the latest imagestreams specs look like.

@frenzymadness
Copy link
Member Author

There are some new fixes in the common module, let's try the latest version.

[test][test-openshift]

@frenzymadness
Copy link
Member Author

Ok, the update od the common module does not help. I'm probably not the best candidate to investigate this issue. @phracek or @hhorak could you please take a look at what is wrong here and why the check for imagestreams doesn't work here?

@pkubatrh
Copy link
Member

Took a quick look at the failures and I think I know what the issue here is. Will follow up with a PR against common scripts.

@pkubatrh
Copy link
Member

Should be fixed by: sclorg/container-common-scripts#169

frenzymadness and others added 3 commits August 28, 2020 08:46
@frenzymadness
Update the common submodule
624df39
@phracek @frenzymadness
Add test for the latest version in imagestreams
bd833d3 
This commit adds check if the latest version is present
in the imagestreams

Python 3.8 is already a part of DockerHub.

https://hub.docker.com/r/centos/python-38-centos7
@frenzymadness
Distgen regenerated content
210e3fa
@frenzymadness
Use --no-deps when testing the latest version of a package
fb27e7e 
Wheel newly depends on packaging so when pip tries to upgrade it
its report also contains an info about installed dependencies
which breaks our test because we want to test only one package
upgrade to test that the latest version is installed.
@frenzymadness
Copy link
Member Author

[test][test-openshift]

@frenzymadness
Copy link
Member Author

Hoooray, we have finally all green. @pkubatrh @phracek do you want to do a final check?

@frenzymadness frenzymadness merged commit ca9b2dc into master Sep 7, 2020
@frenzymadness frenzymadness deleted the test_latest_is_distgen branch April 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frenzymadness @phracek @pkubatrh