Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the latest version in imagestreams #393

Closed
wants to merge 2 commits into from
Closed

Test the latest version in imagestreams #393

wants to merge 2 commits into from

Conversation

phracek
Copy link
Member

@phracek phracek commented Jul 22, 2020

This commit adds support for testing if the latest version is present in imagestreams.

Also, imagestream/python-centos.json is updated into the latest version.
It already exists in https://hub.docker.com/r/centos/python-38-centos7.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jul 22, 2020

[test-openshift]

@phracek
Copy link
Member Author

phracek commented Jul 22, 2020

Fedora infrastructure problem. Let's one more time.

[test]

@phracek
Copy link
Member Author

phracek commented Jul 27, 2020

Fedora failed because of infrastructure outage.

[test][test-openshift]

@frenzymadness
Copy link
Member

The change itself looks good to me. Could you please:

  • squash two updates of the common module to one commit and
  • split the actual change into one commit with the change of sources and another one with distget regenerated content?

This commit adds check if the latest version is present
in the imagestreams

Python 3.8 is already a part of DockerHub.

https://hub.docker.com/r/centos/python-38-centos7

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jul 29, 2020

[test][test-openshift]

@phracek
Copy link
Member Author

phracek commented Jul 30, 2020

[test]

@phracek
Copy link
Member Author

phracek commented Jul 30, 2020

[test-openshift]

@phracek
Copy link
Member Author

phracek commented Aug 4, 2020

It looks like OpenShift tests are failing on gcc compiler.

    creating build/temp.linux-x86_64-3.8
    creating build/temp.linux-x86_64-3.8/psycopg
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -I/opt/rh/rh-python38/root/usr/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -I/opt/rh/rh-python38/root/usr/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DPSYCOPG_DEFAULT_PYDATETIME=1 -DPSYCOPG_VERSION="2.7.3.1 (dt dec pq3 ext)" -DPG_VERSION_NUM=90224 -I/opt/app-root/include -I/opt/rh/rh-python38/root/usr/include/python3.8 -I. -I/usr/include -I/usr/include/pgsql/server -c psycopg/psycopgmodule.c -o build/temp.linux-x86_64-3.8/psycopg/psycopgmodule.o -Wdeclaration-after-statement
    psycopg/psycopgmodule.c: In function ‘psyco_is_main_interp’:
    psycopg/psycopgmodule.c:685:18: error: dereferencing pointer to incomplete type
         while (interp->next)
                      ^
    psycopg/psycopgmodule.c:686:24: error: dereferencing pointer to incomplete type
             interp = interp->next;
                            ^
    error: command 'gcc' failed with exit status 1
    ----------------------------------------
Running setup.py install for psycopg2: finished with status 'error'

@frenzymadness Did you observe this error anytime before?

But this PR does have any affect on OpenShift tests. I think we can merge it and address gcc failure in separate PR.

@phracek
Copy link
Member Author

phracek commented Aug 4, 2020

[test-openshift]

@frenzymadness
Copy link
Member

For the OS tests to work we have to switch django-ex to psycopg2-binary. See sclorg/django-ex#157 and sclorg/django-ex#156

@frenzymadness
Copy link
Member

[test-openshift]

@phracek
Copy link
Member Author

phracek commented Aug 5, 2020

@frenzymadness

11:35:05 Downloading https://files.pythonhosted.org/packages/f9/4e/f4076a1a57fc1e75edc0828db365cfa9005f9f6b4a51b489ae39a91eb4be/gunicorn-19.5.0-py2.py3-none-any.whl (113kB)
11:35:05 ERROR: Could not find a version that satisfies the requirement psycopg2-binary==2.7.3.2 (from -r requirements.txt (line 4)) (from versions: 2.7.4, 2.7.5, 2.7.6, 2.7.6.1, 2.7.7, 2.8, 2.8.1, 2.8.2, 2.8.3, 2.8.4, 2.8.5)
11:35:05 ERROR: No matching distribution found for psycopg2-binary==2.7.3.2 (from -r requirements.txt (line 4))

@frenzymadness
Copy link
Member

[test-openshift]

@frenzymadness
Copy link
Member

All green, hooray! Thank you!

@frenzymadness
Copy link
Member

Unfortunately, there is still an issue with distgen because your commits change source files in version folders directly. I'm gonna open a new PR with your changes adjusted to fit the distgen workflow. Let me know if there is anything unclear.

@phracek
Copy link
Member Author

phracek commented Aug 13, 2020

OK, I will close this one and review yours.

@phracek phracek closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants