Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not end line from readlink with NUL #499

Merged

Conversation

zmiklank
Copy link
Contributor

@phracek
Copy link
Member

phracek commented Feb 15, 2022

This affects only container tests.

[test]

@zmiklank
Copy link
Contributor Author

Hmm, there is the "Couldn't resolve host name for https://mirrors.fedoraproject.org/" bug in the Fedora tests.

@frenzymadness frenzymadness marked this pull request as draft February 18, 2022 09:44
@frenzymadness
Copy link
Member

Thanks for the PR. I've switched it to the draft because we use distgen in this repository so I can transfer the change to it.

@frenzymadness frenzymadness force-pushed the do_not_end_line_with_null_on_readlink branch from 7b0664e to efe920a Compare February 22, 2022 06:07
@frenzymadness
Copy link
Member

So, what I did here is that I split the one commit into two. The first one is the actual change to the source code and the second one contains changes propagated by distgen to the generated folders. This brings the change also to 3.10, omits unsupported version 3.3, and contains also manual change to 3.9-minimal which is not yet covered by distgen.

[test-all]

@frenzymadness frenzymadness marked this pull request as ready for review February 22, 2022 06:10
@frenzymadness
Copy link
Member

There was no need to start OS tests and we know about the issue with Fedora Testing farm. It seems ready to be merged. Any last comments?

@zmiklank
Copy link
Contributor Author

No, thanks for adjusting the PR.

@frenzymadness frenzymadness merged commit b281a34 into sclorg:master Feb 22, 2022
@frenzymadness
Copy link
Member

I thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants