Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove EOL files #462

Merged
merged 1 commit into from Mar 21, 2023
Merged

remove EOL files #462

merged 1 commit into from Mar 21, 2023

Conversation

zmiklank
Copy link
Member

Remove Ruby 2.0, 2.2, 2.3, 2.4, 2.6 as they reached EOL for us.

Please close this PR if you think that removing these files is not yet necessary.

@zmiklank
Copy link
Member Author

[test]

@phracek
Copy link
Member

phracek commented Mar 7, 2023

[test]

@phracek
Copy link
Member

phracek commented Mar 7, 2023

It looks like we have a regression:

+ docker build --no-cache=true --iidfile=/tmp/APP_ID_FILE_DIR_6802/8658 -t myapp .
unknown flag: --iidfile
See 'docker build --help'.
+ echo 'ERROR: The image cannot be built from /root/sclorg/s2i-ruby-container/2.7/test/examples/from-dockerfile/Dockerfile.s2i and application https://github.com/sclorg/rails-ex.git.'
ERROR: The image cannot be built from /root/sclorg/s2i-ruby-container/2.7/test/examples/from-dockerfile/Dockerfile.s2i and application https://github.com/sclorg/rails-ex.git.
+ echo 'Terminating the Dockerfile build.'
Terminating the Dockerfile build.
+ return 1
+ check_result 1
+ local result=1
+ [[ 1 != \0 ]]
+ TESTCASE_RESULT=1
+ return 1
+ ct_check_testcase_result 1
+ local result=1
+ [[ 1 != \0 ]]
+ echo 'Test for image '\''rhscl/ruby-27-rhel7:2.7'\'' FAILED (exit code: 1)'
Test for image 'rhscl/ruby-27-rhel7:2.7' FAILED (exit code: 1)
+ TESTCASE_RESULT=1
+ return 1
++ ct_timestamp_s
++ date +%s
+ time_end=1678184618
+ '[' 1 -eq 0 ']'
+ '[' -n '' ']'
+ test_msg='[FAILED]'

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like on RHEL7 we used docker and we have a regression.

We have to stabilize tests.

@zmiklank
Copy link
Member Author

zmiklank commented Mar 7, 2023

Yes, old common.

When we merge proper cleanup PR, I'll rebase this on master. There is no need to add common in this PR explicitly.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add to the commit message, what versions have been removed?

removed versions are 2.0, 2.2, 2.3, 2.4, 2.5, 2.6.
@zmiklank
Copy link
Member Author

Can you please add to the commit message, what versions have been removed?

The message is now adjusted.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for removing deprecated versions.

@atiratree
Copy link

FYI, I think this is causing CI failures in https://github.com/openshift/oc. I am bumping the version in openshift/oc#1377 to 3.1

@atiratree
Copy link

we will probably need to backport this to all old versions

@atiratree
Copy link

@zmiklank @phracek should references of 2.7 be updated to a newer version in openshift/origin or is there a planned update similar to this PR openshift/origin#25949 ?

referenced eg here:

side question: where can I find the EOL for the 2.7?

@zmiklank
Copy link
Member Author

Hello @atiratree ,

EOL for app streams for RHEL8 and RHEL9 can be found here:
https://access.redhat.com/support/policy/updates/rhel-app-streams-life-cycle.
It is written there that EOL of ruby 2.7 for RHEL8 is planned for March 2023.

@zmiklank @phracek should references of 2.7 be updated to a newer version in openshift/origin or is there a planned update similar to this PR openshift/origin#25949 ?

I, however, am not aware of such update for openshift. Maybe @pkubatrh would know more?

@atiratree
Copy link

in that case it seems we should be indeed also removing references for 2.7 in a week or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants