New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove EOL files #462
remove EOL files #462
Conversation
[test] |
[test] |
It looks like we have a regression: + docker build --no-cache=true --iidfile=/tmp/APP_ID_FILE_DIR_6802/8658 -t myapp .
unknown flag: --iidfile
See 'docker build --help'.
+ echo 'ERROR: The image cannot be built from /root/sclorg/s2i-ruby-container/2.7/test/examples/from-dockerfile/Dockerfile.s2i and application https://github.com/sclorg/rails-ex.git.'
ERROR: The image cannot be built from /root/sclorg/s2i-ruby-container/2.7/test/examples/from-dockerfile/Dockerfile.s2i and application https://github.com/sclorg/rails-ex.git.
+ echo 'Terminating the Dockerfile build.'
Terminating the Dockerfile build.
+ return 1
+ check_result 1
+ local result=1
+ [[ 1 != \0 ]]
+ TESTCASE_RESULT=1
+ return 1
+ ct_check_testcase_result 1
+ local result=1
+ [[ 1 != \0 ]]
+ echo 'Test for image '\''rhscl/ruby-27-rhel7:2.7'\'' FAILED (exit code: 1)'
Test for image 'rhscl/ruby-27-rhel7:2.7' FAILED (exit code: 1)
+ TESTCASE_RESULT=1
+ return 1
++ ct_timestamp_s
++ date +%s
+ time_end=1678184618
+ '[' 1 -eq 0 ']'
+ '[' -n '' ']'
+ test_msg='[FAILED]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like on RHEL7 we used docker and we have a regression.
We have to stabilize tests.
Yes, old common. When we merge proper cleanup PR, I'll rebase this on master. There is no need to add common in this PR explicitly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add to the commit message, what versions have been removed?
removed versions are 2.0, 2.2, 2.3, 2.4, 2.5, 2.6.
The message is now adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for removing deprecated versions.
FYI, I think this is causing CI failures in https://github.com/openshift/oc. I am bumping the version in openshift/oc#1377 to 3.1 |
we will probably need to backport this to all old versions |
@zmiklank @phracek should references of 2.7 be updated to a newer version in openshift/origin or is there a planned update similar to this PR openshift/origin#25949 ? referenced eg here:
side question: where can I find the EOL for the 2.7? |
Hello @atiratree , EOL for app streams for RHEL8 and RHEL9 can be found here:
I, however, am not aware of such update for openshift. Maybe @pkubatrh would know more? |
in that case it seems we should be indeed also removing references for 2.7 in a week or so |
Remove Ruby 2.0, 2.2, 2.3, 2.4, 2.6 as they reached EOL for us.
Please close this PR if you think that removing these files is not yet necessary.