Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svn does not verify client checksum #1113

Closed
sdorra opened this issue Apr 29, 2020 · 2 comments · Fixed by #1128
Closed

svn does not verify client checksum #1113

sdorra opened this issue Apr 29, 2020 · 2 comments · Fixed by #1128
Assignees
@sdorra
Labels
bug Something isn't working

Comments

@sdorra
Copy link
Member

sdorra commented Apr 29, 2020

It looks like that svnkit-dav does not verify the client checksum, which is send with the X-SVN-Result-Fulltext-MD5 header.

https://groups.google.com/d/topic/scmmanager/bhJ3uhP4gHw/discussion
@sdorra sdorra added the bug Something isn't working label Apr 29, 2020
@sdorra sdorra self-assigned this May 2, 2020
@sdorra
Copy link
Member Author

sdorra commented May 2, 2020

svnkit patch: https://github.com/scm-manager/svnkit-patches/blob/master/master/svnkit-dav.verify-client-checksum

@sdorra
Copy link
Member Author

sdorra commented May 2, 2020

Patched version of scm-manager 1.60:

sdorra added a commit that referenced this issue May 4, 2020
@sdorra
#1113 update svnkit to 1.10.1-scm2, in order to validate subversion c…
ce09500 
…lient checksums
@sdorra sdorra mentioned this issue May 4, 2020
Merged
6 tasks
pfeuffer pushed a commit that referenced this issue May 5, 2020
@sdorra @pfeuffer
#1113 update svnkit to 1.10.1-scm2, in order to validate subversion c…
3b53149 
…lient checksums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdorra sdorra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate subversion client checksums scm-manager/scm-manager
1 participant
@sdorra