Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiffCommandRequest - incorrect equals & hashcode #1139

Closed
40rn05lyv opened this issue May 6, 2020 · 1 comment · Fixed by #1136
Closed

DiffCommandRequest - incorrect equals & hashcode #1139

40rn05lyv opened this issue May 6, 2020 · 1 comment · Fixed by #1136
Labels
bug Something isn't working

Comments

@40rn05lyv
Copy link

40rn05lyv commented May 6, 2020 •
edited

DiffCommandRequest has additional fields comparing to its superclass ("format" and "ancestorChangeset"), but doesn't overwrite equals and hashcode methods.
(upd. actually not an issue for now, since it's not used as key for caching)
@pfeuffer
Copy link
Member

pfeuffer commented May 7, 2020

Hi, you are right. Looks like this is the case for other sub classes of FileBaseCommandRequest, too. Thank you for the hint!

@pfeuffer pfeuffer added the bug Something isn't working label May 7, 2020
@pfeuffer pfeuffer mentioned this issue May 7, 2020
Merged
8 tasks
@pfeuffer pfeuffer linked a pull request May 7, 2020 that will close this issue
cleanup outdated jaxb annotations #1136
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup outdated jaxb annotations scm-manager/scm-manager
2 participants
@pfeuffer @40rn05lyv