Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup outdated jaxb annotations #1136

Merged
merged 5 commits into from May 7, 2020

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented May 5, 2020

Proposed changes

Cleanup outdated jaxb annotations and cleanup some classes in general.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch linked an issue May 5, 2020 that may be closed by this pull request
@pfeuffer
Copy link
Member

pfeuffer commented May 6, 2020

This change substitues manual equals and hashCode methods with lombok annotations. The way this is done does not include properties from super classes. Some classes extend BasicPropertiesAware with properties, which would not be included. We should remove this deprecated class first, but this has other implications, because the properties are used in the hg plugin.

@pfeuffer
Copy link
Member

pfeuffer commented May 7, 2020

Fixes #1139 , too

@pfeuffer pfeuffer linked an issue May 7, 2020 that may be closed by this pull request
@pfeuffer pfeuffer merged commit 9952cda into develop May 7, 2020
@pfeuffer pfeuffer deleted the cleanup/remove_outdated_jaxb_annotations branch May 7, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiffCommandRequest - incorrect equals & hashcode @XmlRootElement usage in some classes
2 participants