Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication for repositories with anonymous read access #1081

Merged
merged 1 commit into from Mar 30, 2020

Conversation

pfeuffer
Copy link
Member

Proposed changes

Repositories with anonymous read access could not be written any more,
because for write requests there was no authentication request. This
fixes the check for anonymous access and requests username and
password, again.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

Repositories with anonymous read access could not be written any more,
because for write requests there was no authentication request. This
fixes the check for anonymous access and requests username and
password, again.
@pfeuffer pfeuffer force-pushed the bugfix/authentication_with_anonymous_access branch from 85615d4 to 0ee2aaa Compare March 30, 2020 10:38
@eheimbuch eheimbuch merged commit c11d766 into develop Mar 30, 2020
@eheimbuch eheimbuch deleted the bugfix/authentication_with_anonymous_access branch March 30, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants