Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optional dependency annotation #1097

Merged
merged 12 commits into from Apr 15, 2020

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented Apr 9, 2020

Proposed changes

Create an new annotation to declare classes as dependent on other plugins. Also removed the "requires" attribute on the @extension Annotation since it did the same and we want only one consistent implementation on optional dependencies.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@sdorra sdorra merged commit b9acc7c into develop Apr 15, 2020
@sdorra sdorra deleted the feature/optional_dependency_annotation branch April 15, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants