Show git trailer #1169
Merged
Show git trailer #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eheimbuch
force-pushed
the
feature/show-git-trailer
branch
from
282d5f3
to
0a1cc29
Compare
pfeuffer
force-pushed
the
feature/show-git-trailer
branch
3 times, most recently
from
992fedf
to
6fee31b
Compare
refactor ChangesetAuthor.tsx get interfaces right / fix unit test / cleanup fix table layout use Set constructor injection to bind the implementation for the new changesetTrailers API cleanup / update CHANGELOG.md cleanup fix formatting
Trailes are no persons, they have a person.
Doing so, the trailers are available for other plugins inspecting changesets, not only for the frontend.
The detection of trailers and removing them from the message should be in one place, not divided between classes.
pfeuffer
force-pushed
the
feature/show-git-trailer
branch
from
7374fce
to
9af2bed
Compare
pfeuffer
force-pushed
the
feature/show-git-trailer
branch
from
9af2bed
to
587345b
Compare
pfeuffer
force-pushed
the
feature/show-git-trailer
branch
from
8b836dd
to
79c1057
Compare
We have to use a dedicated component because we have to use the translations from 'plugins', so that other plugins can contribute their own trailer types with their own descriptions.
Doing so will prevent empty collections being added to the trailers.
sdorra
requested changes
Jun 8, 2020
scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/GitChangesetConverter.java
Outdated
Show resolved
Hide resolved
scm-ui/ui-webapp/src/repos/components/changesets/ContributorTable.tsx
Outdated
Show resolved
Hide resolved
scm-ui/ui-webapp/src/repos/components/changesets/ContributorTable.tsx
Outdated
Show resolved
Hide resolved
scm-ui/ui-webapp/src/repos/components/changesets/ContributorTable.tsx
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/repository/ChangesetDescriptionTrailerProvider.java
Outdated
Show resolved
Hide resolved
One processor can be used to process multiple chagesets of one repository. Therefore each processing needs a new clean working environment.
Should be fixed witch changes to |
sdorra
approved these changes
Jun 10, 2020
pfeuffer
requested changes
Jun 11, 2020
Co-authored-by: René Pfeuffer <rene.pfeuffer@cloudogu.com>
…-manager into feature/show-git-trailer
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create changeset trailer from description and "committed by" tag from git. Show trailers on changeset details view in a table.
Your checklist for this pull request
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Checklist for branch merge request (not required for forks)