Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file lists #1191

Merged
merged 2 commits into from Jun 17, 2020
Merged

Close file lists #1191

merged 2 commits into from Jun 17, 2020

Conversation

pfeuffer
Copy link
Member

Proposed changes

Though we could not reproduce an error even with real big file
structures (100 directories, containing each another 100 directories
with 100 files each), it may be safer to make sure the streams will
really be closed in the end and recommended in the javadoc description
for Files#list
(https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#list-java.nio.file.Path-)

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

Though we could not reproduce an error even with real big file
structures (100 directories, containing each another 100 directories
with 100 files each), it may be safer to make sure the streams will
really be closed in the end and recommended in the javadoc description
for Files#list
(https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#list-java.nio.file.Path-)
@pfeuffer pfeuffer force-pushed the bugfix/close_file_list_in_migration branch from c441028 to 7f3f47c Compare June 16, 2020 09:51
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch merged commit 2d709fe into develop Jun 17, 2020
@eheimbuch eheimbuch deleted the bugfix/close_file_list_in_migration branch June 17, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants