Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mind custom directories for repository types in migration #1201

Merged
merged 2 commits into from Jun 18, 2020

Conversation

pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Jun 17, 2020

Proposed changes

In the migration of the repositories from 1.x to 2.x we did not mind
the possibility, that you could configure custom directories for the
different repository types in 1.x. With this fix we read these
configurations (when they exist) to find the correct repository
directories.

Fixes #1193

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@pfeuffer pfeuffer force-pushed the bugfix/mind_custom_repo_dir_in_migration branch 2 times, most recently from 04c97ed to 7d5aad6 Compare June 17, 2020 14:10
In the migration of the repositories from 1.x to 2.x we did not mind
the possibility, that you could configure custom directories for the
different repository types in 1.x. With this fix we read these
configurations (when they exist) to find the correct repository
directories.
@pfeuffer pfeuffer force-pushed the bugfix/mind_custom_repo_dir_in_migration branch from 7d5aad6 to 4079b73 Compare June 17, 2020 14:31
@sdorra sdorra added the bug Something isn't working label Jun 17, 2020
@sdorra sdorra self-assigned this Jun 18, 2020
@sdorra sdorra merged commit 7443166 into develop Jun 18, 2020
@sdorra sdorra deleted the bugfix/mind_custom_repo_dir_in_migration branch June 18, 2020 05:27
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Plan execution doesn't detect custom paths for repositories
2 participants