Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete revision decoding to utf 8 #1315

Merged
merged 2 commits into from Sep 1, 2020

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented Sep 1, 2020

Proposed changes

The UrlDecoder replaced the "+" for a space which is wrong. Remove the revision decoding for sources view since it's obsolete.

Your checklist for this pull request

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • CHANGELOG.md updated

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the bug Something isn't working label Sep 1, 2020
@eheimbuch eheimbuch linked an issue Sep 1, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdorra sdorra merged commit 1a3d23a into develop Sep 1, 2020
@sdorra sdorra deleted the bugfix/branchname_with_plus branch September 1, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GIT branches with '+' not supported by UI
2 participants