Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default branch in branch selector if nothing is selected #1338

Merged
merged 4 commits into from Sep 21, 2020

Conversation

fscholdei
Copy link
Member

Proposed changes

When clicking on the "changesets" shortcut on repository overview you ended up on the correct page, but the branch selector always highlights the first branch. This pr sets the default branch in branch selector if nothing is selected.

Your checklist for this pull request

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@eheimbuch
Copy link
Member

Also please resolve the new conflict.

@eheimbuch eheimbuch merged commit a8d1bf0 into develop Sep 21, 2020
@eheimbuch eheimbuch deleted the bugfix/branchselector_default_entry branch September 21, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants