Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fullscreen #1376

Merged
merged 10 commits into from Oct 20, 2020
Merged

Feature/fullscreen #1376

merged 10 commits into from Oct 20, 2020

Conversation

fscholdei
Copy link
Member

Proposed changes

Source code of a file (also diff view in PR and editor) can be displayed in full screen view.

Your checklist for this pull request

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

eheimbuch
eheimbuch requested changes Oct 19, 2020
View reviewed changes
scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/components/content/SourcecodeViewer.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/components/content/SourcecodeViewer.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/components/content/SourcecodeViewer.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/components/content/SourcecodeViewer.tsx Outdated Show resolved Hide resolved
scm-ui/ui-components/src/buttons/OpenInFullscreenButton.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx Outdated Show resolved Hide resolved
scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx Outdated Show resolved Hide resolved
@eheimbuch
Copy link
Member

I discussed your modal layout with UXP and we both think it looks fine. 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

46.5% 46.5% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch merged commit 42c5ed1 into develop Oct 20, 2020
@eheimbuch eheimbuch deleted the feature/fullscreen branch October 20, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eheimbuch eheimbuch eheimbuch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fscholdei @eheimbuch