Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/syntax highlighting #1382

Merged
merged 27 commits into from Oct 22, 2020
Merged

Feature/syntax highlighting #1382

merged 27 commits into from Oct 22, 2020

Conversation

Pilopa
Copy link
Contributor

@Pilopa Pilopa commented Oct 20, 2020

Proposed changes

Centralise syntax highlighting and add mechanism for deploying ui content.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

sdorra and others added 27 commits June 16, 2020 21:04
…eature/syntax-highlighting

# Conflicts:
#	package.json
#	scm-ui/eslint-config/package.json
#	scm-ui/ui-components/src/SyntaxHighlighter.tsx
#	scm-ui/ui-components/src/repos/annotate/Annotate.tsx
#	scm-ui/ui-plugins/package.json
#	yarn.lock
We remove @scm-manager/ prefix and add append .bundle.js before loading
modules.
…com:scm-manager/scm-manager into feature/syntax-highlighting
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sdorra sdorra added the enhancement New feature or request label Oct 22, 2020
@sdorra sdorra merged commit e557c3a into develop Oct 22, 2020
@sdorra sdorra deleted the feature/syntax-highlighting branch October 22, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants