Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing redirect after login #1592

Merged
merged 1 commit into from Mar 16, 2021
Merged

Fix missing redirect after login #1592

merged 1 commit into from Mar 16, 2021

Conversation

sdorra
Copy link
Member

@sdorra sdorra commented Mar 16, 2021

Proposed changes

Each unauthorized error was caught by the token expired handler, which has reset the whole query state and this leads sometimes to a missing redirect after login.

Your checklist for this pull request

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@sdorra sdorra added the bug Something isn't working label Mar 16, 2021
Each unauthorized error was caught by the token expired handler, which has reset the whole query state and this leads sometimes to a missing redirect after login.
@eheimbuch eheimbuch merged commit 9ef076f into develop Mar 16, 2021
@eheimbuch eheimbuch deleted the bugfix/flappy_login branch March 16, 2021 15:13
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants