Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct positioning and coloring of button groups in modals #1612

Merged
merged 5 commits into from Apr 7, 2021
Merged

Correct positioning and coloring of button groups in modals #1612

merged 5 commits into from Apr 7, 2021

Conversation

fscholdei
Copy link
Member

Proposed changes

Specify positioning and coloring of button groups in style guide

Your checklist for this pull request

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@fscholdei fscholdei added the bug Something isn't working label Apr 5, 2021
@fscholdei fscholdei changed the title Correct button groups Correct positioning and coloring of button groups in modals Apr 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdorra sdorra merged commit 84ba05b into develop Apr 7, 2021
@sdorra sdorra deleted the bugfix/correct_button_groups branch April 7, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fscholdei @sdorra