Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remark rehype #1622

Merged
merged 11 commits into from Apr 21, 2021
Merged

Feature/remark rehype #1622

merged 11 commits into from Apr 21, 2021

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented Apr 20, 2021

Proposed changes

Make remark compatible with rehype plugins so we can sanitize the content with rehype-sanitize-plugin.

Your checklist for this pull request

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Apr 20, 2021
@eheimbuch
Copy link
Member Author

eheimbuch commented Apr 20, 2021

In general most stuff seems to be working like expected. Good job!

I couldn't manage to test the issuetracker links in markdown. How did you test it?

@eheimbuch
Copy link
Member Author

When i want to use anchor links for headers with some special characters (e.g. Compl_icated_H€aDer) the anchor doesn't work properly.

@eheimbuch eheimbuch merged commit b5d4d7f into develop Apr 21, 2021
@eheimbuch eheimbuch deleted the feature/remark-rehype branch April 21, 2021 10:05
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

73.0% 73.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants