Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve repository information page #1636

Merged
merged 6 commits into from Apr 29, 2021
Merged

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented Apr 27, 2021

Proposed changes

Only show relevant information for repository on repository information page. The initialization code example is only shown if the repository is still empty.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Apr 27, 2021
…on page. The initialization block is only shown if the repository is still empty.
@eheimbuch eheimbuch force-pushed the feature/improve_repo_info_page branch from f028d3b to 3cafa89 Compare April 27, 2021 14:59
@eheimbuch eheimbuch marked this pull request as ready for review April 27, 2021 15:01
@eheimbuch eheimbuch force-pushed the feature/improve_repo_info_page branch from 06bdbe2 to c577eec Compare April 28, 2021 11:17
@eheimbuch eheimbuch force-pushed the feature/improve_repo_info_page branch from 99cda72 to ac5fe8a Compare April 29, 2021 06:49
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

49.2% 49.2% Coverage
0.0% 0.0% Duplication

@Pilopa Pilopa merged commit af8980d into develop Apr 29, 2021
@Pilopa Pilopa deleted the feature/improve_repo_info_page branch April 29, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants