Fix sse for notifications behind nginx reverse proxy #1650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes SSE Events for notifications if SCM-Manager is running behind an Nginx reverse proxy. The notifications do not work behind Nginx, because Nginx buffers the response. This change will add the
X-Accel-Buffering: no
response header to notification subscribe endpoint. TheX-Accel-Buffering: no
header tells nginx to stop buffering for this endpoint.Your checklist for this pull request
Contributor:
gradle/changelog
or CHANGELOG.md is updated for pluginsReviewer:
Checklist for branch merge request (not required for forks)