Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TrustManagerProvider #1654

Merged
merged 1 commit into from May 12, 2021
Merged

Add TrustManagerProvider #1654

merged 1 commit into from May 12, 2021

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented May 11, 2021 •
edited

Proposed changes

Add trust manager provider

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label May 11, 2021
@eheimbuch eheimbuch force-pushed the feature/trust_manager_provider branch from 2af2a8d to 1256624 Compare May 11, 2021 09:52
@sdorra sdorra added the do not merge Marks a pr that it should not merged yet label May 11, 2021
@eheimbuch eheimbuch force-pushed the feature/trust_manager_provider branch from 1256624 to c8729cb Compare May 11, 2021 12:00
pfeuffer
pfeuffer reviewed May 12, 2021
View reviewed changes
Copy link
Member

@pfeuffer pfeuffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every existing old class is a good guide ;-)

scm-webapp/src/main/java/sonia/scm/net/TrustManagerProvider.java Outdated Show resolved Hide resolved
scm-webapp/src/main/java/sonia/scm/net/TrustManagerProvider.java Outdated

@Named("default")
@Inject(optional = true)
private Provider<TrustManager> trustManagerProvider;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar doesn't like this field name. And indeed it does not reveal its intention. What about customTrustManagerProvider?

scm-webapp/src/test/java/sonia/scm/net/TrustManagerProviderTest.java Outdated

import static org.assertj.core.api.Assertions.assertThat;

@ExtendWith(MockitoExtension.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mockito is not used here

@eheimbuch eheimbuch force-pushed the feature/trust_manager_provider branch 2 times, most recently from 6ffd5e2 to 6990b7d Compare May 12, 2021 06:42
@eheimbuch eheimbuch force-pushed the feature/trust_manager_provider branch from 6990b7d to 85b8f7a Compare May 12, 2021 06:53
@pfeuffer pfeuffer merged commit a71766a into develop May 12, 2021
@pfeuffer pfeuffer deleted the feature/trust_manager_provider branch May 12, 2021 06:56
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

76.0% 76.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeuffer pfeuffer pfeuffer left review comments

Assignees
No one assigned
Labels
do not merge Marks a pr that it should not merged yet enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eheimbuch @pfeuffer @sdorra