Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SVN mirror command #1660

Closed
wants to merge 15 commits into from
Closed

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented May 17, 2021

Proposed changes

Implement mirror command for Subversion.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

pfeuffer and others added 2 commits May 17, 2021 08:51
Simplifies the class RepositoryTypeSupportChecker. There is no need to fall back to the super type Type`.
So we do not need to manually check for type safety.

Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
@eheimbuch eheimbuch changed the title Add POC for SVN mirror command Implement SVN mirror command May 17, 2021
@eheimbuch eheimbuch force-pushed the feature/svn_mirror branch 2 times, most recently from 91a2caa to fd3275a Compare May 17, 2021 14:00
pfeuffer and others added 5 commits May 19, 2021 11:24
Add list of emergency contacts to global configuration. This user will receive e-mails and notification if some serious system error occurs like repository health check failed.
Update jgit to v5.11.1.202105131744-r-scm1

Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

52.1% 52.1% Coverage
0.0% 0.0% Duplication

@pfeuffer pfeuffer closed this May 25, 2021
@pfeuffer pfeuffer deleted the branch feature/git_mirror May 25, 2021 09:26
@pfeuffer pfeuffer deleted the feature/svn_mirror branch May 25, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants