Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadOnlyCheck ExtensionPoint #1662

Merged
merged 5 commits into from
May 18, 2021
Merged

ReadOnlyCheck ExtensionPoint #1662

merged 5 commits into from
May 18, 2021

Conversation

sdorra
Copy link
Member

@sdorra sdorra commented May 18, 2021

Proposed changes

The ReadOnlyCheck extension point can be used by plugins to protect a repository from write access.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

pfeuffer and others added 3 commits May 17, 2021 08:51
@pfeuffer @eheimbuch
Simplify type support check (#1658)
20bf646 
Simplifies the class RepositoryTypeSupportChecker. There is no need to fall back to the super type Type`.
So we do not need to manually check for type safety.

Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
@Pilopa
fix repository form switcher button label translations for plugins
cb6806a
@sdorra
Add ReadOnlyCheck extension point
6786b39 
The ReadOnlyCheck extension point can be used by plugins to protect a repository from write access.
@sdorra sdorra added enhancement New feature or request do not merge Marks a pr that it should not merged yet and removed do not merge Marks a pr that it should not merged yet labels May 18, 2021
@sdorra sdorra marked this pull request as draft May 18, 2021 12:54
@sdorra sdorra marked this pull request as ready for review May 18, 2021 13:19
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

73.8% 73.8% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch merged commit 500248c into feature/git_mirror May 18, 2021
@eheimbuch eheimbuch deleted the feature/repo_readonly_api branch May 18, 2021 16:00
sdorra added a commit that referenced this pull request Jun 2, 2021
@sdorra @pfeuffer
@eheimbuch @Pilopa
ReadOnlyCheck ExtensionPoint (#1662)
61ee87b 
The ReadOnlyCheck extension point can be used by plugins to protect a repository from write access.

Co-authored-by: René Pfeuffer <rene.pfeuffer@cloudogu.com>
Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Co-authored-by: Konstantin Schaper <konstantin.schaper@cloudogu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdorra @eheimbuch @pfeuffer @Pilopa