Keep whole lines for code highlighting in search #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 24, 2021
Comment on lines
76
to
82
| int c = index; | ||
| while (c > 0) { | ||
| c--; | ||
| if (content.charAt(c) == '\n') { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not use public int lastIndexOf(int ch, int fromIndex)?
There was a problem hiding this comment.
I think it is not possible here to use lastIndexOf, because we need not the next line ending from the position. We need the previous (c-- vs c++).
scm-webapp/src/main/java/sonia/scm/search/LuceneHighlighter.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/search/LuceneHighlighter.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We now use SimpleSpanFragmenter with a fragment size of 200 for each highlighted field. For code fields we ensure that each line is complete.
Your checklist for this pull request
Contributor:
gradle/changelogor CHANGELOG.md is updated for pluginsReviewer:
Checklist for branch merge request (not required for forks)