Sorted autocomplete #1918

pfeuffer · 2022-01-12T09:48:21Z

Proposed changes

Users, groups, repositories and repository roles have been sorted in the rest layer by default if no other sort option was given. In the layers "below" (aka the manager classes or the dao), the collections have been unsorted. This led to the effect, that the autocomplete resource, which did not sort all values beforehand, returned unsorted results. As a sideeffect, direct matches for an input could occur at a random position or not at all (as reported in #1695), when there were enough other matches.

With this pull request the databases for users, groups, repositories and repository roles will use instances of TreeMap instead of LinkedHashMap internally, so that these values are sorted implicitly (by id respectively name for users, groups and repository roles and namespace/name for repositories).

Due to this change the default sort applied in the rest layer could be removed.

Fixes #1695

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

PR is well described and the description can be used as a commit message on squash
Related issues linked to PR if existing and labels set
New code is covered with unit tests
Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
Feature has been tested with different permissions

Reviewer:

The clean code principles are respected (CleanCode)
All new code/logic is implemented on the right spot / "Should this be done here?"
UI changes fits into the layout
The UI views / components are responsive (mobile views)
Correct translations are available