Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent corrupt lfs files during transfer #2068

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Conversation

eheimbuch
Copy link
Member

@eheimbuch eheimbuch commented Jun 17, 2022

Proposed changes

Validate lfs file checksum to ensure that the file was transferred successfully. If an error occur delete the blob to prevent corrupt files inside the storage.

Fixes #2043

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New/updated ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

…ccessfully. If an error occur delete the blob to prevent corrupt files inside the storage.
@eheimbuch eheimbuch added the bug Something isn't working label Jun 17, 2022
@eheimbuch eheimbuch changed the title Prevent corrupt lfs files after transfer Prevent corrupt lfs files during transfer Jun 17, 2022
Copy link
Member

@pfeuffer pfeuffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small remarks 👍🏽

eheimbuch and others added 2 commits June 20, 2022 19:44
Co-authored-by: René Pfeuffer <rene.pfeuffer@cloudogu.com>
@pfeuffer pfeuffer changed the base branch from develop to master June 21, 2022 12:27
@pfeuffer pfeuffer changed the base branch from master to develop June 21, 2022 12:28
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pfeuffer pfeuffer merged commit 8b5347b into develop Jun 21, 2022
@pfeuffer pfeuffer deleted the bugfix/lfs_corrupt_files branch June 21, 2022 14:31
@eheimbuch eheimbuch mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LFS is giving incorrect hash
2 participants