Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark read only permissions #8

Merged
merged 2 commits into from Dec 16, 2020
Merged

Conversation

pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Dec 14, 2020

Proposed changes

Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477)

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@pfeuffer pfeuffer force-pushed the feature/mark_read_only_permissions branch from 8543e07 to 5177e5d Compare December 14, 2020 14:39
CHANGELOG.md Outdated Show resolved Hide resolved
@eheimbuch eheimbuch merged commit 3631f75 into develop Dec 16, 2020
@eheimbuch eheimbuch deleted the feature/mark_read_only_permissions branch December 16, 2020 10:01
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants