Archive repository #1477
Merged
Archive repository #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2020
pfeuffer
force-pushed
the
feature/archive_repository
branch
from
3ce0a83
to
9bd881a
Compare
eheimbuch
reviewed
Dec 15, 2020
eheimbuch
requested changes
Dec 15, 2020
scm-core/src/main/java/sonia/scm/repository/EventDrivenRepositoryArchiveCheck.java
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/PermissionProvider.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/EventDrivenRepositoryArchiveCheck.java
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/RepositoryArchivedCheck.java
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/RepositoryManager.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/api/v2/resources/RepositoryResource.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/SystemRepositoryPermissionProvider.java
Outdated
Show resolved
Hide resolved
|
Please mind the sonarcloud findings |
eheimbuch
reviewed
Dec 15, 2020
eheimbuch
requested changes
Dec 15, 2020
eheimbuch
reviewed
Dec 15, 2020
eheimbuch
reviewed
Dec 15, 2020
eheimbuch
reviewed
Dec 15, 2020
…cm-manager into feature/archive_repository
|
Kudos, SonarCloud Quality Gate passed!
|
eheimbuch
pushed a commit
to scm-manager/scm-review-plugin
that referenced
this pull request
Dec 16, 2020
Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477)
eheimbuch
added a commit
to scm-manager/scm-teamscale-plugin
that referenced
this pull request
Dec 16, 2020
Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477) Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
eheimbuch
added a commit
to scm-manager/scm-ci-plugin
that referenced
this pull request
Dec 16, 2020
Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477) Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
eheimbuch
added a commit
to scm-manager/scm-statistic-plugin
that referenced
this pull request
Dec 16, 2020
Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477) Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
eheimbuch
added a commit
to scm-manager/scm-commit-message-checker-plugin
that referenced
this pull request
Dec 16, 2020
Marks read only verbs that may be executed, when a repository is marked as "archived" (scm-manager/scm-manager#1477) Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds a flag "archived" to repositories. Repositories marked with this can no longer be modified in any way. To do this, we switch to a new version of Shiro Static Permissions (sdorra/shiro-static-permissions#4) and specify a permission guard to check for every permission request, whether the repository in question is archived or not. Further we implement checks in stores and other activies so that no writing request may be executed by mistake.
Your checklist for this pull request
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Checklist for branch merge request (not required for forks)