Support negative values for VarLongCodec
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support negative values for `VarLongCodec`.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These days I'm revisiting all the stuff around
VarIntCodec/VarLongCodecbecause I plan to add support for signed zig-zag encoding for a side project I'm working on (a pure Scala Kafka protocol implementation).It draw my attention though that
VarLongCodecdoesn't support negative values. According to the original PR :But I don't see a reason for not supporting them 馃. In fact, the implementation used in Kafka codebase supports it out-of-the-box and I can't see any argument against it in the Wikipedia link from the original PR.
Please, let me know if I'm missing something 馃檹馃徑